Skip to content

fix(ios): Added missing Frame backstack disposal handling #10672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Jan 22, 2025

PR Checklist

What is the current behavior?

Upon disposal, iOS frame does not dispose its page views resulting in memory leaks or accessible native view references that have already been affected by GC.
That goes for current, executing, and backstack pages.

What is the new behavior?

Frame will dispose all owning page views upon its disposal.

@CatchABus CatchABus changed the title Fix/ios frame cleanup fix(ios): Added missing Frame backstack disposal handling Jan 22, 2025
@NathanWalker NathanWalker added this to the 8.9 milestone Jan 22, 2025
@NathanWalker NathanWalker merged commit 5f8fb2c into NativeScript:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants