Skip to content

fix(ios): Broken transform if set before any layout #10675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix(ios): Broken transform if set before any layout #10675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions packages/core/ui/core/view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export class View extends ViewCommon implements ViewDefinition {
private _modalAnimatedOptions: Array<boolean>;
private _isLaidOut = false;
private _hasTransform = false;
private _hasPendingTransform = false;
private _privateFlags: number = PFLAG_LAYOUT_REQUIRED | PFLAG_FORCE_LAYOUT;
private _cachedFrame: CGRect;
private _suspendCATransaction = false;
Expand All @@ -68,7 +67,6 @@ export class View extends ViewCommon implements ViewDefinition {
this._cachedFrame = null;
this._isLaidOut = false;
this._hasTransform = false;
this._hasPendingTransform = false;
}

public requestLayout(): void {
Expand Down Expand Up @@ -140,10 +138,6 @@ export class View extends ViewCommon implements ViewDefinition {
}

this.updateBackground(sizeChanged, needsLayout);
if (this._hasPendingTransform) {
this.updateNativeTransform();
this._hasPendingTransform = false;
}
this._privateFlags &= ~PFLAG_FORCE_LAYOUT;
}

Expand Down Expand Up @@ -400,11 +394,6 @@ export class View extends ViewCommon implements ViewDefinition {
}

public updateNativeTransform() {
if (!this.isLayoutValid) {
this._hasPendingTransform = true;
return;
}

const scaleX = this.scaleX || 1e-6;
const scaleY = this.scaleY || 1e-6;
const perspective = this.perspective || 300;
Expand Down
Loading