fix(core): Pseudo-class handlers failing to unsubscribe listeners #10680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, even if a view is unloaded, pseudo-class listeners will not be disposed.
At the same time, once view is loaded again, pseudo-class handlers will add new listeners resulting in a leak.
There's also another case of iOS button which can keep reference of their previous native view if removed and re-added to the view tree. That is also a defect caused by missing pseudo-class handlers cleanup.
What is the new behavior?
This PR ensures that pseudo-class handlers will follow the subscription cycle of adding and removing listeners.