fix(core): ignore inserting child if < 0 #10690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 3 commits into main from fix/insert-child-negative

Feb 5, 2025

Contributor

NathanWalker commented Feb 5, 2025 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

A throw could occur during layout introduced from this change which would bubble out to a v8 engine crash:
https://github.com/NativeScript/NativeScript/pull/10679/files#diff-ff996ba7476badc71c6c2ce6924be412385d3ea43a8785248a28159b3f7d203eR54

What is the new behavior?

Just ignore inserting children if < 0.

Notes: Usage of CollectionView surfaced this issue.


          fix(core): ignore inserting child if < 0

3de0735

NathanWalker requested a review from CatchABus

February 5, 2025 03:36

NathanWalker added this to the 8.9 milestone

CatchABus requested changes

View reviewed changes

packages/core/ui/layouts/layout-base-common.ts Show resolved Hide resolved

NathanWalker added 2 commits

February 5, 2025 09:33


          fix(core): return boolean on insertChild for when handled

e547686


          chore: cleanup

d4f9c80

CatchABus approved these changes

View reviewed changes

NathanWalker merged commit 2305511 into main

2 of 3 checks passed

NathanWalker deleted the fix/insert-child-negative branch

February 5, 2025 17:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet