fix(core): Added missing inheritance support for text css properties #10699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:feat/text-inheritable-props

Feb 18, 2025

Contributor

CatchABus commented Feb 17, 2025

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the new behavior?

This PR adds missing inheritance support for some text-base properties according to MDN docs:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform#formal_definition
https://developer.mozilla.org/en-US/docs/Web/CSS/text-shadow#formal_definition
https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-stroke#formal_definition
https://developer.mozilla.org/en-US/docs/Web/CSS/white-space#formal_definition


          fix(core): Added missing inheritance support for text css properties

4dd2a8f

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into feat/text-inheritable-props

ceaa6c4

NathanWalker added this to the 8.9 milestone

NathanWalker merged commit 70e7248 into NativeScript:main

0 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet