feat(css): allow infinity values within css calc expressions #10705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into main from feat/css-calc-infinity

Feb 21, 2025

Contributor

NathanWalker commented Feb 21, 2025 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Tailwind 4, for example, uses css calc expressions, some of which contain infinity values. These would not be processed properly.

What is the new behavior?

The infinity value will now properly evaluate to get expected styling results.


          feat(css): allow infinity values within css calc expressions

5642fd1

NathanWalker added this to the 8.9 milestone

NathanWalker requested a review from CatchABus

February 21, 2025 22:41

NathanWalker merged commit 24116c5 into main

3 checks passed

NathanWalker deleted the feat/css-calc-infinity branch

February 21, 2025 22:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet