fix(core): Added missing parameter for once event listeners #10715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:fix/event-listener-once

Mar 3, 2025

Contributor

CatchABus commented Mar 3, 2025

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Right now, View event listeners registered using once don't get removed upon being called.

What is the new behavior?

View event listeners registered using once will behave as expected.

CatchABus added 2 commits

March 3, 2025 16:11


          fix(core): Added missing parameter for once event listeners

e25b80d


          chore: Corrected parameter description

105a533

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 852011c into NativeScript:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet