Skip to content

fix(ios): listview incorrect measurement #10740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the current behavior?

On iOS, there are times ListView skips needed measure updates. That is because method measure is overridden and performs a check that causes defects.
See: https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/list-view/index.ios.ts#L396

Calling _setCurrentMeasureSpecs may indicate whether size changed but also updates previous measure spec values, resulting in skipping measure update in the super.measure() call.

What is the new behavior?

iOS ListView will undergo measurements as expected.

Copy link

nx-cloud bot commented May 20, 2025

View your CI Pipeline Execution ↗ for commit 5df817f.

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 2m 23s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-20 19:41:25 UTC

@NathanWalker NathanWalker merged commit 8393df1 into NativeScript:main May 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants