Skip to content

Cankov/xml source tracing #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2015
Merged

Cankov/xml source tracing #1125

merged 3 commits into from
Nov 25, 2015

Conversation

PanayotCankov
Copy link
Contributor

Add line and column information in the XML parser events.
Add ui/builder test.
Add nested Errors.
Add test that a proper error is thrown when unknown element is met while building a Page.
Add test that a proper error is thrown when template is realized.

Closes #501

@ns-bot ns-bot added cla: yes and removed cla: no labels Nov 20, 2015
@ns-bot
Copy link

ns-bot commented Nov 20, 2015

Test FAILed.

@PanayotCankov
Copy link
Contributor Author

UI-BUILDER will be moved to XML-DECLARATION

@PanayotCankov PanayotCankov force-pushed the cankov/xml-source-tracing branch from 80b1d4d to 2265798 Compare November 23, 2015 13:04
@ns-bot
Copy link

ns-bot commented Nov 23, 2015

Test PASSed.

@ns-bot
Copy link

ns-bot commented Nov 24, 2015

Test FAILed.

@vakrilov
Copy link
Contributor

👍

@PanayotCankov PanayotCankov force-pushed the cankov/xml-source-tracing branch from cc033ef to 586a5c0 Compare November 25, 2015 11:39
@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

@PanayotCankov PanayotCankov force-pushed the cankov/xml-source-tracing branch from 586a5c0 to 3225f32 Compare November 25, 2015 13:24
@PanayotCankov PanayotCankov added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed in progress labels Nov 25, 2015
@PanayotCankov PanayotCankov force-pushed the cankov/xml-source-tracing branch from 3225f32 to 5447b04 Compare November 25, 2015 13:33
@hshristov
Copy link
Contributor

🔢

@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

1 similar comment
@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

PanayotCankov added a commit that referenced this pull request Nov 25, 2015
@PanayotCankov
Merge pull request #1125 from NativeScript/cankov/xml-source-tracing
b577f84 
Cankov/xml source tracing
@PanayotCankov PanayotCankov merged commit b577f84 into master Nov 25, 2015
@PanayotCankov PanayotCankov mentioned this pull request Nov 30, 2015
Merged
@PanayotCankov PanayotCankov deleted the cankov/xml-source-tracing branch November 30, 2015 14:39
@PanayotCankov PanayotCankov mentioned this pull request Dec 1, 2015
Merged
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes ready for test TSC needs to test this and confirm against live production apps and automated test suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better XML declaration error reporting for non-existing element
4 participants
@PanayotCankov @ns-bot @vakrilov @hshristov