Skip to content

setItem event fixed #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2015
Merged

setItem event fixed #1154

merged 2 commits into from
Nov 25, 2015

Conversation

enchev
Copy link
Contributor

@enchev enchev commented Nov 25, 2015

Fixed #1142

@ns-bot ns-bot added cla: yes and removed cla: no labels Nov 25, 2015
@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

@dtopuzov
Copy link
Contributor

👍

@@ -567,7 +592,7 @@ export var test_ObservableArray_lastIndexOfShouldReturnCorrectIndex = function (
var result = array.lastIndexOf("two");
// ```
// </snippet>
TKUnit.assert(result === 2, "ObservableArray lastIndexOf() should return correct index!");
TKUnit.assert(result === 2, "ObservableArray lastIndexOf() should return correct index!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation

@hshristov
Copy link
Contributor

👍

2 similar comments
@ErjanGavalji
Copy link
Contributor

👍

@nsndeck
Copy link

nsndeck commented Nov 25, 2015

👍

// <snippet module="data/observable-array" title="observable-array">
// ### Set item at specified index using setItem(index, item) method and observe change event data.
// ``` JavaScript
var index : number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space: index: instead of index :

@PanayotCankov
Copy link
Contributor

👍

enchev pushed a commit that referenced this pull request Nov 25, 2015
@enchev enchev merged commit df9f997 into master Nov 25, 2015
@enchev enchev deleted the observable-array-fix branch November 25, 2015 11:54
@ns-bot
Copy link

ns-bot commented Nov 25, 2015

Test PASSed.

@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableArray does not provide removed items through EventData when an UPDATE action occurs
8 participants