Skip to content

Time picker interval #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Time picker interval #1170

merged 1 commit into from
Nov 30, 2015

Conversation

enchev
Copy link
Contributor

@enchev enchev commented Nov 27, 2015

partially implemented #1109

@ns-bot ns-bot added cla: yes and removed cla: no labels Nov 27, 2015
@enchev enchev force-pushed the time-picker-interval branch from 4b25ac6 to 878776e Compare November 27, 2015 11:26
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.minuteInterval;
var expectedValue = 1;
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use assertEqual for better error reporting when test fails.

@enchev enchev force-pushed the time-picker-interval branch from 21ca687 to ea6fa31 Compare November 27, 2015 13:01
@ns-bot
Copy link

ns-bot commented Nov 27, 2015

Test PASSed.

@ErjanGavalji
Copy link
Contributor

👍

1 similar comment
@nsndeck
Copy link

nsndeck commented Nov 30, 2015

👍

enchev pushed a commit that referenced this pull request Nov 30, 2015
@enchev enchev merged commit 163bfe2 into master Nov 30, 2015
@enchev enchev deleted the time-picker-interval branch November 30, 2015 07:54
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants