hhristov/recycle native view android #3885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakrilov
approved these changes
Mar 28, 2017
| this.nativeView = this._iosView = (<any>this)._nativeView; | ||
| this.createNativeView(); | ||
| if (!currentNativeView) { | ||
| console.log(`${this.typeName} doesnt have NativeView !!!!! =================`); |
| } | ||
| } | ||
|
|
||
| [maxDateProperty.getDefault](): Date { | ||
| return this.android.getMaxDate(); | ||
| return this.nativeView.getMaxDate(); |
There was a problem hiding this comment.
Return type should be number
| } | ||
| } | ||
|
|
||
| [maxDateProperty.getDefault](): Date { | ||
| return this.android.getMaxDate(); | ||
| return this.nativeView.getMaxDate(); | ||
| } | ||
| [maxDateProperty.setNative](value: Date) { |
There was a problem hiding this comment.
value type should be Date | number
| } | ||
|
|
||
| [minDateProperty.getDefault](): Date { | ||
| return this.android.getMinDate(); | ||
| return this.nativeView.getMinDate(); |
There was a problem hiding this comment.
Return type should be number
| } | ||
|
|
||
| // public _resetNativeView(force?: boolean) { |
|
|
||
| public onMeasure(widthMeasureSpec: number, heightMeasureSpec: number): void { | ||
| var nativeView = this._nativeView; | ||
| var nativeView = this._ios; |
| } | ||
|
|
||
| const validTime = getValidTime(timePicker, hour, minute); | ||
| hourProperty.nativeValueChange(timePicker, validTime.hour); |
There was a problem hiding this comment.
delete those - not needed
vchimev
approved these changes
Mar 28, 2017
added 4 commits
March 28, 2017 18:08
createNativeView will set iOS nativeView if it is null/undefined
d2ace2f to
e6250e7
Compare
|
widgets |
|
widgets-uitests-android |
|
widgets-uitests-ios |
|
there are some failures for iOS that require to look into them. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename:
_createNativeView to createNativeView;
_initNativeView to initNativeView
_disposeNativeView to disposeNativeView
_resetNativeView to resetNativeView