Call native setters once when a page is instantiated #4227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf5742e to
c5ea8a1
Compare
7b0a9cc to
b09a049
Compare
aae5da9 to
30b3815
Compare
30b3815 to
1da79fc
Compare
hshristov
reviewed
Jun 7, 2017
| @@ -36,7 +36,7 @@ export class Slider extends SliderBase { | |||
|
|
|||
| constructor() { | |||
| super(); | |||
| this.nativeView = this._ios = UISlider.new(); | |||
| this.setNativeView(this._ios = UISlider.new()); | |||
There was a problem hiding this comment.
could be this.nativeView = ...
hshristov
approved these changes
Jun 7, 2017
| @@ -83,4 +83,7 @@ export class Switch extends SwitchBase { | |||
| [backgroundInternalProperty.setNative](value: any) { | |||
There was a problem hiding this comment.
It will be hard for developers to not apply backgroundColor
1da79fc to
4eef759
Compare
|
run uitests |
Call native setters once when a page is instantiated. Fix background not being reset, Label's background is now set to background, not layer Make the nativeView field instead of property for performance reasons
4eef759 to
1f521f3
Compare
|
run uitests |
1 similar comment
|
run uitests |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.