-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Do not change the Android layer types (hardware/software) #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
run ci |
This comment was marked as abuse.
This comment was marked as abuse.
Yea, I read that, A little while ago I removed some of the ops that were clipping images. Clipping with paths were not applying antialiasing on the images so they looked terrible anyway. Containers may not clip content when with rounded corners but that would be rarely a problem. In general I think we should not mess internally with the rendering mode. "Hardware acceleration is enabled by default if your Target API level is >=14" and we will now never set it to software, so layers instead of forced to software every once in a while by {N}, should stay hardware all the time. Now since we do not enable/disable hardware acceleration I think you can control it (e.g. on the windows) and it will be inherited by the views down the hierarchy. Or at least you can use the Can you actually try the next versions of the widgets and the tns-core-modules in your app and verify that there is a performance hit? |
run ci |
1 similar comment
run ci |
run android |
run ci |
Hey, @PanayotCankov could try to rebase this pull request. |
At one time, I think Enchev and I went back and forth on fixing an Android issue and it required changing the layer type. I can't recall the specifics, it was probably in late 2015 when I was working on some initial plugins for android components but something didn't work and we started stumbling on the layer types. If I find it, I'll drop a link. This might be totally unrelated but just wanted to throw it out there 😄 |
Ah so it was @vakrilov who helped, Enchev just cleaned up 👍 |
@bradmartin I think before we relied on Canvas clipping to round the button, and clipping was not antialiased and was not working properly on some devices, unless software mode is set. I think I prefer to keep the defaults now since the geometry is drawn for the button background using different Canvas APIs. If the issue reoccur, I'd like to rather provide a property on the view to control the rendering mode. |
d1d3a19
to
c80235d
Compare
uitests |
animations |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I don't know why we did this in the first place,
but changing the rendering mode can not be good.
Let's re-run all possible UI tests.