Added @profile on several key methods in the Android lifecycle, refactored by extracting into methods a little #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
hshristov
approved these changes
Aug 17, 2017
There was a problem hiding this comment.
Although I understand the need to profile I still don't like this syntax and the fact that I need to change how I write code in order to profile it. IMO this makes is harder to read.
const notifyActivityCreated = profile("notifyActivityCreated", function(activity: android.app.Activity, savedInstanceState: android.os.Bundle) {
| } | ||
|
|
||
| @profile | ||
| private setContentView(activity: android.app.Activity): void { |
There was a problem hiding this comment.
Why do we pass activity here?
|
run ci |
2 similar comments
|
run ci |
|
run ci |
…tored by extracting into methods a little
5a6f340 to
f0faddb
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.