-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: typo on android utils, getPalleteColor to getPaletteColor #4687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo on android utils, getPalleteColor to getPaletteColor #4687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I like the change this is a breaking change.
It would be safer if you leave the old method there just for compatibility and mark it as obsolete. Also in the Obsolete decorator and API help specify the newer method.
@hshristov totally agree with letting the old method, but i don't know what you mean by "Also in the Obsolete decorator and API help specify the newer methods." can you point me an example ? |
@danielgek We have |
@danielgek Thanks for the PR! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pr Fixes #4647 .