Skip to content

fix: typo on android utils, getPalleteColor to getPaletteColor #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2017
Merged

fix: typo on android utils, getPalleteColor to getPaletteColor #4687

merged 2 commits into from
Aug 24, 2017

Conversation

danielgek
Copy link
Contributor

This pr Fixes #4647 .

@ghost ghost added the ♥ community PR label Aug 10, 2017
Copy link
Contributor

@hshristov hshristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I like the change this is a breaking change.
It would be safer if you leave the old method there just for compatibility and mark it as obsolete. Also in the Obsolete decorator and API help specify the newer method.

@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@NativeScript NativeScript deleted a comment from ns-bot Aug 17, 2017
@danielgek
Copy link
Contributor Author

@hshristov totally agree with letting the old method, but i don't know what you mean by "Also in the Obsolete decorator and API help specify the newer methods." can you point me an example ?

@hshristov
Copy link
Contributor

@danielgek We have @Deprecated TypeScript decorator but apparently you cannot pass arguments to it. So comment is also good enough :)

@vakrilov
Copy link
Contributor

@danielgek Thanks for the PR!

@vakrilov vakrilov merged commit 7b36461 into NativeScript:master Aug 24, 2017
@ghost ghost removed the ♥ community PR label Aug 24, 2017
@danielgek danielgek deleted the fix-typo-on-utils-android branch August 24, 2017 09:21
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils.ad.getPalleteColor should be named getPaletteColor
4 participants