Enable evaluating in Chrome Console (#3405) #4713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome calls compileScript method when an expression is evaluated in the console. So to enable the console evaluate add an empty compileScript implementation. Also send an Runtime.executionContextCreated which is needed for Console evaluation. Both of the command and the event do not exist in the Webkit protocol, so we cannot use InspectorBackendCommands definition file
|
Please sign CLA at http://www.nativescript.org/cla |
|
Related to NativeScript/ios-jsc#787 |
PanayotCankov
approved these changes
Aug 18, 2017
pkoleva
approved these changes
Aug 18, 2017
|
This also fixes the previously non-working Watch expressions. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherrypick of the commits by #3405 which where lost in the 2.5 -> 3.0 migration.
@pkoleva Can you verify the Chrome console eval works with this fix?