Skip to content

TypeScript 2.5 compatibility #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2017
Merged

TypeScript 2.5 compatibility #4794

merged 1 commit into from
Sep 4, 2017

Conversation

vakrilov
Copy link
Contributor

@vakrilov vakrilov commented Sep 4, 2017

No description provided.

@ghost ghost assigned vakrilov Sep 4, 2017
@ghost ghost added the in progress label Sep 4, 2017
@ns-bot ns-bot added the cla: yes label Sep 4, 2017
@SvetoslavTsenov SvetoslavTsenov merged commit 28b6eba into master Sep 4, 2017
@ghost ghost removed the in progress label Sep 4, 2017
@SvetoslavTsenov SvetoslavTsenov deleted the tsc25 branch September 4, 2017 11:36
sis0k0
sis0k0 reviewed Sep 4, 2017
View reviewed changes
tns-core-modules/ui/styling/style-properties.ts
function normalizeTransformation({ property, value }: Transformation) {
return STYLE_TRANSFORMATION_MAP[property](value);
function normalizeTransformation({ property, value }: Transformation): Transformation {
return <any>STYLE_TRANSFORMATION_MAP[property](value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that cast needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript cannot assure that all callbacks from STYLE_TRANSFORMATION_MAP actually return Transformation

vchimev pushed a commit that referenced this pull request Sep 5, 2017
@SvetoslavTsenov
TypeScript 2.5 compatibility (#4794)
2f0e89a
SvetoslavTsenov pushed a commit that referenced this pull request Sep 5, 2017
@tsonevn @SvetoslavTsenov
edit broken page snippet tag (#4776)
ea9213b 
* edit broken page snippet tag

* Increase timeout for HTTP tests (#4775)

* Typos (#4789)

* TypeScript 2.5 compatibility (#4794)

* edit broken page snippet tag

* fix(date-picker): Date picker changed check (#4797)

* edit broken page snippet tag
vchimev pushed a commit that referenced this pull request Sep 7, 2017
@tsonevn @SvetoslavTsenov
edit broken page snippet tag (#4776)
80dc648 
* edit broken page snippet tag

* Increase timeout for HTTP tests (#4775)

* Typos (#4789)

* TypeScript 2.5 compatibility (#4794)

* edit broken page snippet tag

* fix(date-picker): Date picker changed check (#4797)

* edit broken page snippet tag
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sis0k0 sis0k0 sis0k0 left review comments

@SvetoslavTsenov SvetoslavTsenov SvetoslavTsenov approved these changes

Assignees

@vakrilov vakrilov

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vakrilov @SvetoslavTsenov @sis0k0 @ns-bot