Improve ImageAsset scaling #5110
Conversation
|
Please sign CLA at http://www.nativescript.org/cla |
ae91354 to
06230ae
Compare
|
uitests-ios-pickers |
|
CLA signature found, happy contributing! |
|
tests widgets#test api25 uitests |
|
test widgets#tachev/improve-images-handling api25 uitests |
1 similar comment
|
test widgets#tachev/improve-images-handling api25 uitests |
|
👍 |
|
Hey @DimitarTachev, could you please rebase again. |
d8a3950 to
bfc26a7
Compare
|
test widgets#tachev/improve-images-handling api25 uitests |
|
any update when this will be merged? |
|
test widgets#tachev/improve-images-handling |
|
test branch_widgets#tachev/improve-images-handling |
1 similar comment
|
test branch_widgets#tachev/improve-images-handling |
…tch property and Asset options.
… its more specific.
… to unify it with the Android implementation, support for relative files and file not found support errors.
bfc26a7 to
aee37d2
Compare
|
test branch_widgets#tachev/improve-images-handling |
|
👍 |
| reqHeight = (options.height > 0 && options.height < reqHeight) ? options.height : reqHeight; | ||
| } | ||
| var reqWidth = options.width || src.width; | ||
| var reqHeight = options.height || src.height; |
There was a problem hiding this comment.
Fall back to min(src.width, platform.screen.mainScreen.widthDIPs * density)
platform.screen.mainScreen.width?
| return; | ||
| } | ||
|
|
||
| const async = this.loadMode === ASYNC; | ||
| let decodeWidth = this.decodeWidth; |
| @@ -348,6 +348,7 @@ | |||
| setRotationAngle(angle: number): void; | |||
|
|
|||
| setUri(uri: string, decodeWidth: number, decodeHeight: number, useCache: boolean, async: boolean): void; | |||
There was a problem hiding this comment.
Consider removing setUri
Check if called without keepAspectRatio
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixing issue #3955 and camera plugin issue #26