Fix background scale quality #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SvetoslavTsenov merged 1 commit into NativeScript:master from dbenninger:5112-background-image-scaling

Dec 5, 2017

Contributor

dbenninger commented Nov 30, 2017

UIGraphicsBeginImageContextWithOptions with scale factor 0 makes sure the device scale factor is used automatically and not 1.0

Fixes/Implements #5112.


          Fix background scale quality

8029c6b

UIGraphicsBeginImageContextWithOptions with scale factor 0 makes sure the device scale factor is used automatically and not 1.0

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

22 similar comments

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ns-bot commented Nov 30, 2017

Can one of the admins verify this patch?

ghost added the ♥ community PR label

ns-bot commented Nov 30, 2017

Please sign CLA at http://www.nativescript.org/cla

ns-bot added the cla: no label

ns-bot commented Nov 30, 2017

CLA signature found, happy contributing!

ns-bot added cla: yes and removed cla: no labels

dbenninger mentioned this pull request

Fix scaling of background images on iOS #5112

Closed

Contributor

vakrilov commented Dec 4, 2017

run ci
uitests

vakrilov approved these changes

View reviewed changes

PanayotCankov approved these changes

View reviewed changes

Contributor

PanayotCankov left a comment

Let's have QAs run all ui tests

Contributor

SvetoslavTsenov commented Dec 5, 2017

uitests

Contributor

SvetoslavTsenov commented Dec 5, 2017

animations

Contributor

SvetoslavTsenov commented Dec 5, 2017

cuteness

SvetoslavTsenov merged commit 634cf9a into NativeScript:master

vchimev pushed a commit that referenced this pull request


          Revert "Fix background scale quality (#5113)"

cc8d93b

This reverts commit 634cf9a.

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes ♥ community PR