Skip to content

[Do not merge - WIP] feat(android): Add a 'profiling: lifecycle' to track startup times #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PanayotCankov
Copy link
Contributor

@PanayotCankov PanayotCankov commented Jan 24, 2018

Consider this a very light-weight mode of 'profiling: timline'.
By adding in the app/package.json a:

{
  "profiling": "lifecycle"
}

The app will print out the time it takes to launch the app.
In future, we can add times for navigation, time to respond user interaction, etc.

@ghost ghost assigned PanayotCankov Jan 24, 2018
@ghost ghost added the in progress label Jan 24, 2018
@sis0k0 sis0k0 force-pushed the profiling-lifecycle branch from 16cd580 to 70555b0 Compare January 27, 2018 12:06
@ghost ghost assigned sis0k0 Jan 27, 2018
@vchimev vchimev force-pushed the profiling-lifecycle branch from 70555b0 to efbc502 Compare February 6, 2018 15:07
@ghost ghost assigned vchimev Feb 6, 2018
@NativeScript NativeScript deleted a comment from SvetoslavTsenov Feb 6, 2018
@NativeScript NativeScript deleted a comment from SvetoslavTsenov Feb 6, 2018
@vchimev vchimev changed the title feat: Add a 'profiling: lifecycle' to track startup times [WIP] [Do not merge - WIP] feat(android): Add a 'profiling: lifecycle' to track startup times Feb 6, 2018
@vchimev vchimev force-pushed the profiling-lifecycle branch from efbc502 to f953ee8 Compare February 7, 2018 12:43
@vchimev vchimev force-pushed the profiling-lifecycle branch from f953ee8 to 3cd2459 Compare April 23, 2018 12:39
@vchimev vchimev force-pushed the profiling-lifecycle branch from 3cd2459 to 2b2d834 Compare April 24, 2018 05:45
@vchimev vchimev requested a review from MartoYankov April 24, 2018 06:35
@vchimev
Copy link
Contributor

vchimev commented Apr 24, 2018

Closing this pull request as it tries to hack, but not to resolve the problems below:

  • What exactly do we want to measure of the launch of Android application?" - the pull request doesn't give an answer to this question. It moves raising of displayedEvent later, but this does not guarantee that it will include the drawing of all elements in the application. For example, the ListView draws its elements async, so some of them take part of the displayedEvent, but not all. In order to count on the displayEvenet approach, we would need to draw all the native elements sync.

  • rootView._onAttachedToWindow() is hijacked only for the case when the root of the application is Frame. We would need a more general approach for all the scenarios.

Attached the timeline-view times - please remove the .log extension in order to preview:
template-hello-world-ng@4.0.0.html.log
template-hello-world-ng@pr.html.log

@vchimev vchimev closed this Apr 24, 2018
@ghost ghost removed the in progress label Apr 24, 2018
@vchimev vchimev deleted the profiling-lifecycle branch April 24, 2018 13:43
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants