fix(ios-action-bar): NavigationButton text change on first navigation #5458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakrilov
approved these changes
Feb 23, 2018
| @@ -86,6 +88,11 @@ export class Frame extends FrameBase { | |||
| backstackEntry[NAV_DEPTH] = navDepth; | |||
| viewController[ENTRY] = backstackEntry; | |||
|
|
|||
| if (majorVersion > 10) { | |||
There was a problem hiding this comment.
Can you pls add a comment in the code explaining why this is necessary, as the fix is not obvious :)
59e4651 to
14ce89f
Compare
|
@ADjenkov Won't this remove all back buttons? |
manoldonev
reviewed
Feb 27, 2018
| @@ -86,6 +88,13 @@ export class Frame extends FrameBase { | |||
| backstackEntry[NAV_DEPTH] = navDepth; | |||
| viewController[ENTRY] = backstackEntry; | |||
|
|
|||
| if (majorVersion > 10) { | |||
There was a problem hiding this comment.
Maybe extend condition to if (!animated && majorVersion > 10) ?
manoldonev
approved these changes
Feb 27, 2018
14ce89f to
ee60214
Compare
MartoYankov
approved these changes
Feb 28, 2018
|
test |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: NavigationButton (a.k.a back button) won't change its title on first navigation when there
is no transition animation - iOS 11+ only.
The solution: Set empty back button title on the parent view controller when navigating
For reference: stackoverflow1 and stackoverflow2
Fix #5169