Skip to content

feat(modal): introduce stretched param to showModal method #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2018
Merged

feat(modal): introduce stretched param to showModal method #5496

merged 3 commits into from
Mar 7, 2018

Conversation

ADjenkov
Copy link
Contributor

@ADjenkov ADjenkov commented Mar 6, 2018

No description provided.

@ADjenkov ADjenkov self-assigned this Mar 6, 2018
@ghost ghost added the in progress label Mar 6, 2018
@ADjenkov
Copy link
Contributor Author

ADjenkov commented Mar 6, 2018

test testsappng

@ADjenkov ADjenkov changed the title fix-next(ios-modal-view): force stretch alignment feat(modal): introduce stretched param to showModal method Mar 6, 2018
@ADjenkov
Copy link
Contributor Author

ADjenkov commented Mar 6, 2018

test branch_testsappng

@ADjenkov
Copy link
Contributor Author

ADjenkov commented Mar 6, 2018

test testsappng

@hshristov
Copy link
Contributor

hshristov commented Mar 6, 2018 •
edited
Loading

@ADjenkov What's the point of removing the code that sets horizontal & vertical alignments and later introduce stretched which sets the same properties?

(there was a previous commit that removed the horizontalAlignment="center")

@SvetoslavTsenov
Copy link
Contributor

test branch_testsappng#master

@ADjenkov
Copy link
Contributor Author

ADjenkov commented Mar 7, 2018

@hshristov The previous commit that removed the horizontalAlignment="center" was pretty much a Breaking Change and you had to manually set horizontalAlignment="center" and verticalAlignment="middle" on the root visual element you are showing modally - Page e.g. But in Angular we wrap the components that we are navigating to in Page and you can't manually set horizontalAlignment .

@SvetoslavTsenov
Copy link
Contributor

👍

@SvetoslavTsenov SvetoslavTsenov merged commit 0138873 into master Mar 7, 2018
@ghost ghost removed bug in progress labels Mar 7, 2018
@SvetoslavTsenov SvetoslavTsenov deleted the djenkov/modal-view-stretch branch March 7, 2018 16:17
vchimev added a commit that referenced this pull request Mar 15, 2018
@vchimev
refactor(e2e/modal-navigation): stretch modal tab view
84e18d6 
Update application with #5496.
@vchimev vchimev mentioned this pull request Mar 15, 2018
Merged
vchimev pushed a commit that referenced this pull request Mar 16, 2018
refactor(e2e/modal-navigation): stretch modal tab view (#5548)
8248d8a 
Update application with #5496.
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartoYankov MartoYankov MartoYankov approved these changes

@manoldonev manoldonev Awaiting requested review from manoldonev

Assignees

@ADjenkov ADjenkov

Labels
ns-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADjenkov @hshristov @SvetoslavTsenov @MartoYankov