Skip to content

refactor(e2e/modal-navigation): stretch modal tab view #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018
Merged

refactor(e2e/modal-navigation): stretch modal tab view #5548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions e2e/modal-navigation/app/home/home-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,17 @@ export function onModalPage(args: EventData) {
}

export function onModalTabView(args: EventData) {
const fullscreen = false;
const animated = false;
const stretched = true;

const view = args.object as View;
view.showModal("modal-tab/modal-tab-root",
{ frameless: true },
() => console.log("home-page modal tabview closed"),
false);
fullscreen,
animated,
stretched);
}

export function onNavigate(args: EventData) {
Expand All @@ -57,5 +63,5 @@ export function onNavigate(args: EventData) {

export function onRootViewChange() {
let rootView = application.getRootView();
rootView instanceof Frame ? application._resetRootView({moduleName: "tab-root"}) : application._resetRootView({moduleName: "app-root"});
rootView instanceof Frame ? application._resetRootView({ moduleName: "tab-root" }) : application._resetRootView({ moduleName: "app-root" });
}