fix(debugger): Enable iOS inspector modules on creation #6904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakrilov
approved these changes
Feb 15, 2019
When the application is being debugged with `--debug-brk --bundle` options, the JS implementation objects handling the debugging protocol are created after their corresponding domains' `enable` methods have been called by the debugger frontend. As a workaround we now manually call `enable` in their constructors. related to NativeScript/ios-jsc#1055 and NativeScript/ios-jsc#1057
502e471 to
1b5d307
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application is being debugged with
--debug-brk --bundleoptions, the JS implementation objects handling the debugging protocol
are created after their corresponding domains'
enablemethods havebeen called by the debugger frontend. As a workaround we now manually
call
enablein their constructors.related to NativeScript/ios-jsc#1055 and NativeScript/ios-jsc#1057
PR Checklist
What is the current behavior?
The Elements, DOM, CSS, and Networking inspector modules are enabled when the
enableevent is received from the debugger.What is the new behavior?
The Elements, DOM, CSS, and Networking inspector modules are enabled explicitly in their constructors.