Skip to content

fix(text): crash when removing FormattedText #7237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2019

Conversation

vakrilov
Copy link
Contributor

PR Checklist

What is the current behavior?

See NativeScript/nativescript-angular#1818

What is the new behavior?

App no longer crashes

Fixes NativeScript/nativescript-angular#1818

@ghost ghost assigned vakrilov May 13, 2019
@cla-bot cla-bot bot added the cla: yes label May 13, 2019
@ghost ghost added in progress and removed cla: yes labels May 13, 2019
@SvetoslavTsenov
Copy link
Contributor

test sdk_ng

@cla-bot cla-bot bot added the cla: yes label May 13, 2019
@dtopuzov
Copy link
Contributor

test sdk_ng

@SvetoslavTsenov
Copy link
Contributor

test sdk_ng nativescript-angular#/tns-dist/nativescript-angular/PR/fac8bf7c5491842e48a15a06c86121a59ec58b8b/nativescript-angular-7.2.4.tgz

@vakrilov vakrilov merged commit 37b53c6 into release May 13, 2019
@ghost ghost removed the in progress label May 13, 2019
@vakrilov vakrilov deleted the fix-formatted-string-parent-crash branch May 13, 2019 14:03
manoldonev pushed a commit that referenced this pull request May 15, 2019
* fix(text): crash when removing FormattedText

* refactor: fixed crash on ios too
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants