refactor(bottom-navigation): strip item creation #7477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartoYankov
reviewed
Jul 9, 2019
| function createTabItemSpec(tabStripItem: TabStripItem): org.nativescript.widgets.TabItemSpec { | ||
| const result = new org.nativescript.widgets.TabItemSpec(); | ||
| result.title = tabStripItem.title; | ||
| function createTabItemSpec(item: TabStripItem): org.nativescript.widgets.TabItemSpec { |
There was a problem hiding this comment.
I think TabStripItems should be named tabStripItem instead of item to avoid confusion with the TabContentItems which are the items in the tab navigation classes.
3535be3 to
ac7a5ab
Compare
manoldonev
approved these changes
Jul 10, 2019
ac7a5ab to
fa1ce44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This pull request refactors strip item creation for both Android and iOS.
Implements NativeScript/nativescript-angular#1893.
Rebase and merge after #7466.