feat: add CSS classes to app/modal root views to target platform/device/orientation/type #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vchimev merged 6 commits into master from vchimev/root-views-css-classes

Aug 19, 2019

Contributor

vchimev commented Jul 29, 2019

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the new behavior?

Add a CSS class to the application/modal root view as follows:

application root view

default
- .ns-root
platform
- .ns-ios
- .ns-android
device type
- .ns-phone
- .ns-tablet
orientation
- .ns-portrait
- .ns-landscape

modal root view

default
- .ns-modal

Depends on #7602.
Implements #7313.

cla-bot bot added the cla: yes label

vchimev requested review from manoldonev, MartoYankov, ADjenkov and vakrilov

July 29, 2019 16:42

manoldonev reviewed

View reviewed changes

tests/app/ui/styling/root-views-css-classes-tests.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tests/app/ui/styling/root-views-css-classes-tests.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tests/app/ui/styling/root-views-css-classes-tests.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tns-core-modules/application/application-common.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tns-core-modules/application/application-common.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tns-core-modules/application/application-common.ts Outdated Show resolved Hide resolved

manoldonev reviewed

View reviewed changes

tns-core-modules/application/application.d.ts Outdated Show resolved Hide resolved

MartoYankov added the docs needed label

MartoYankov reviewed

View reviewed changes

tests/app/ui/styling/root-views-css-classes-tests.ts Outdated Show resolved Hide resolved

MartoYankov reviewed

View reviewed changes

tns-core-modules/application/application.ios.ts Outdated Show resolved Hide resolved

MartoYankov reviewed

View reviewed changes

tns-core-modules/platform/platform.ios.ts Outdated Show resolved Hide resolved

vchimev force-pushed the vchimev/root-views-css-classes branch 3 times, most recently from 62e4707 to f6cba6d Compare

August 18, 2019 11:45

vchimev added 2 commits

August 18, 2019 17:26


          feat: add default CSS classes to app/modal root views

561a2ff

Add CSS classes to app/modal root views to target platform/device/orientation/type.


          refactor(Android): remove modal view default background color

3a2d062

vchimev force-pushed the vchimev/root-views-css-classes branch from b7b8a0d to 3a2d062 Compare

August 18, 2019 14:26

vchimev and others added 4 commits

August 18, 2019 17:31


          e2e: remove css-classes app

6a38b5c


          test(iOS): remove an unnecessary verification

417a999

Addressed by #6637.


          test: address comments

b7b45cd


          Merge branch 'master' into vchimev/root-views-css-classes

3d5105c

vchimev requested a review from bundyo

August 19, 2019 08:20

manoldonev reviewed

View reviewed changes

tns-core-modules/ui/core/view/view.android.ts Show resolved Hide resolved

manoldonev approved these changes

View reviewed changes

vchimev merged commit 3adba68 into master

vchimev deleted the vchimev/root-views-css-classes branch

August 19, 2019 11:09

bundyo mentioned this pull request

Changing rootView className replaces all platform classes #7709

Closed

manoldonev mentioned this pull request

ViewBase.className & cssClasses output should be in sync #7756

Open

m-abs mentioned this pull request

Add platform/orientation/device/type CSS classes to modal-views #7822

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MartoYankov MartoYankov left review comments

manoldonev manoldonev approved these changes

ADjenkov Awaiting requested review from ADjenkov

vakrilov Awaiting requested review from vakrilov

bundyo Awaiting requested review from bundyo

Labels

cla: yes docs needed