Skip to content

fix(tabs-android): tabStripItem color not applied #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix(tabs-android): tabStripItem color not applied #7617

merged 1 commit into from
Aug 1, 2019

Conversation

ADjenkov
Copy link
Contributor

  • Expose new onTabsViewPagerPageChanged to TabStrip class that does not call updateTabsTextColor

  • Introduce new TabsBar java class to be used by Tabs. Currently it differs only by calling onTabsViewPagerPageChanged of TabStrip instead of onViewPagerPageChanged.

  • Refactor tabs.android.ts to use the new TabsBar java class

Fix #7495

@ADjenkov ADjenkov added the patch label Jul 31, 2019
@ADjenkov ADjenkov self-assigned this Jul 31, 2019
@cla-bot cla-bot bot added the cla: yes label Jul 31, 2019
@ADjenkov ADjenkov merged commit 2518655 into release Aug 1, 2019
@ADjenkov ADjenkov deleted the djenkov/tabs-bar branch August 1, 2019 07:02
vakrilov pushed a commit that referenced this pull request Aug 2, 2019
@ADjenkov
fix(tabs-android): tabStripItem color not applied (#7617)
faa94bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartoYankov MartoYankov MartoYankov approved these changes

Assignees

@ADjenkov ADjenkov

Labels
cla: yes patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADjenkov @MartoYankov