Skip to content

fix: dots can now be used in module names #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

surdu
Copy link
Contributor

@surdu surdu commented Aug 7, 2019

PR Checklist

What is the current behavior?

If you have a module name with a dot in it, the code fails

What is the new behavior?

Only pre-defined extensions are stripped from the end of module names

Fixes #7646

@cla-bot cla-bot bot added the cla: yes label Aug 7, 2019
Only known extensions are stripped from the end of module names
@SvetoslavTsenov
Copy link
Contributor

test

@SvetoslavTsenov
Copy link
Contributor

test --ignore ngapps api24

@SvetoslavTsenov SvetoslavTsenov merged commit b6ff4d3 into NativeScript:master Aug 20, 2019
@surdu surdu deleted the fix-sanitize branch August 25, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules that have names ending in .page are not found
3 participants