Skip to content

fix(hmr): close modal views during livesync #7668 #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

VladimirAmiorkov
Copy link
Contributor

PR Checklist

What is the current behavior?

Any opened modal views are not updated or closed during HMR livesync

What is the new behavior?

Any opened modal views are closed during HMR livesync

Fixes/Implements/Closes #[Issue Number].
#7668

chore: add unit tests to test that modal views are closed during hmr
@SvetoslavTsenov
Copy link
Contributor

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants