fix: expose orientation to application module #7832

vchimev · 2019-09-16T15:42:16Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

There is orientation property exposed to androidApp and iOSApp (#7602).
However, the application module itself is missing orientation.

The application module has exposed orientation.

Fixes #7815.

vchimev added 2 commits September 16, 2019 17:59

test: application orientation

6f8dcbd

fix: expose orientation to application module

2124d9d

cla-bot bot added the cla: yes label Sep 16, 2019

vchimev changed the title ~~Vchimev/orientation~~ fix: expose orientation to application module Sep 16, 2019

vchimev mentioned this pull request Sep 16, 2019

bug: application.orientation #7815

Closed

ADjenkov approved these changes Sep 19, 2019

View reviewed changes

Merge branch 'release' into vchimev/orientation

ff451a2

manoldonev approved these changes Sep 19, 2019

View reviewed changes

manoldonev added the patch label Sep 19, 2019

manoldonev merged commit 4166e2d into release Sep 19, 2019

manoldonev deleted the vchimev/orientation branch September 19, 2019 15:49