-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(textview): added maxLines property #7943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18cd36f
to
a3b25c8
Compare
a3b25c8
to
974bdb1
Compare
@surdu The I think you should move this property to the |
c3af9e1
to
25f55d2
Compare
870edfb
to
97b2244
Compare
@MartoYankov done |
Hi, @surdu , sorry for the delayed response. This looks good, however I see that the feature behaves differently on iOS and Android right now.
The -1 value on Android is also the default one, so it's important to not crash when resetting CSS rules for example. Also the 0 value should reset to the default behavior. I see that on Android they are doing this by setting it to integer max value. |
Also, the |
Hey @surdu |
7dcc40c
to
1975774
Compare
@vakrilov I did the 2 changes you asked for, but I don't have time right now to look over the default value issue mentioned by Martin Yankov. I'll do my best to also fix that problem by Monday. Sorry, I was really busy these past weeks 😞 |
1ead5f2
to
ca7e6c4
Compare
@MartoYankov Now when you set the value to 0 or -1 works the same on android as well. Here is the commit that changed the behavior on Android. |
test |
test --ignore |
PR Checklist
What is the current behavior?
TextView doesn't have a way to limit the maximum number of lines
What is the new behavior?
TextView has a way to limit the maximum number of lines by specifying the
maxLines
property.Fixes #4315