Skip to content

chore: add no android.R tslint rule #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2019
Merged

Conversation

vakrilov
Copy link
Contributor

PR Checklist

What is the new behavior?

Enable the no-android-resources rule from @nativescript/tslint-rules that checks there are no android.R.xxx property access in the codebase as they cause performance issues.

Note: Build currently failing as they are android.R usages. Should be OK after fixes are merged from release branch

@cla-bot cla-bot bot added the cla: yes label Oct 29, 2019
@SvetoslavTsenov
Copy link
Contributor

test --ignore

@SvetoslavTsenov SvetoslavTsenov merged commit eb960b7 into master Nov 7, 2019
@SvetoslavTsenov SvetoslavTsenov deleted the android-r-tslint-rule branch November 7, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants