feat(dialogs): Setting the size of popup dialog thru dialog options #8041

slolam · 2019-10-31T02:41:30Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

There is no way to set the size of the popup dialog on iOS

What is the new behavior?

This will allow to size the popup dialogs in iOS (primarily iPad based apps, for iPhone apps iOS ignores these properties). Here is the playground project to test https://play.nativescript.org/?template=play-ng&id=GeR8Q4&v=3

Pulling master from NativeScript source

…ller

…ade optional

vakrilov · 2019-12-02T15:45:10Z

test

slolam · 2019-12-02T16:01:20Z

@vakrilov, how do I get to see the logs/details of the tests failed? By clicking on details, it is looking for nsbuild01.telerik.com which seems to be a internal DNS entry.

vakrilov · 2019-12-03T09:54:27Z

Hey @slolam
Can you please run npm run api-extractor in the root of the repo and then commit the changes in the NativeScript.api.md file. This is needed because this PR is changing the public API of the framework.

This should make the travis build green.

slolam · 2019-12-03T16:59:34Z

Hey @vakrilov,

sh: api-extractor: command not found it looks like I am missing some dependencies

cla-bot · 2019-12-03T17:09:50Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

slolam · 2019-12-03T17:12:00Z

@vakrilov, never mind I did not update the npm packages. I have committed the NativeScript.api.md

cla-bot · 2019-12-03T17:28:06Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2019-12-03T17:36:03Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

vakrilov · 2019-12-03T20:08:50Z

test

vakrilov · 2019-12-04T07:58:58Z

Hey @slolam
Seems that the CLA bot is not satisfied any more (this might happen if you have changed you git config settings or if you have pushed a commit from another machine). Can you try signing the CLA again?

cla-bot · 2019-12-04T16:12:23Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

slolam · 2019-12-04T16:17:16Z

@vakrilov, yes, I have committed from a different machine earlier. I committed again from the previous machine but still the CLA bot has hung up previous commit that had issue. Not sure how you want me to undo my previous commit. Could you please help me with this?

cla-bot · 2019-12-05T07:56:15Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2019-12-05T08:45:32Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Shailesh Lolam.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

dtopuzov · 2019-12-05T08:47:50Z

test

vakrilov · 2019-12-05T12:30:09Z

Tests are green. I've checked the CLA seems to be OK. Thanks @slolam !
Merging.

slolam · 2019-12-05T16:09:42Z

Thanks @vakrilov for your help !

…ativeScript#8041) * Added iOS specific height and width attributes to ShowModalOptions * Set the height and width of the popup dialog to the presenting controller * dialog options ios attributes presentationStyle, height & width are made optional * Updated NativeScript.api.md for public API changes * Update with git properties * Public API * CLA update

* feat: add 3d rotation * chore: fix build errors * chore: fix tslint errors * chore: add @types/chai dev dep * chore: unused import cleanup * chore: update tests for x,y rotation * chore: rebase upstream/master * fix: iOS Affine Transform test verification * feat(css): Added optional css-tree parser (#8076) * feat(css): Added optional css-tree parser * test: css-tree parser compat tests * test: more css-tree compat tests * feat(dialogs): Setting the size of popup dialog thru dialog options (#8041) * Added iOS specific height and width attributes to ShowModalOptions * Set the height and width of the popup dialog to the presenting controller * dialog options ios attributes presentationStyle, height & width are made optional * Updated NativeScript.api.md for public API changes * Update with git properties * Public API * CLA update * fix: use iOS native-helper for 3d-rotate * test: Fix tests using _getTransformMismatchError * fix: view.__hasTransfrom not set updating properly * test: fix css-animations test page Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com> Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com> Co-authored-by: Shailesh Lolam <slolam@live.com> Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>

slolam added 3 commits October 30, 2019 18:46

Merge pull request #1 from NativeScript/master

9532d5a

Pulling master from NativeScript source

Added iOS specific height and width attributes to ShowModalOptions

66e3da2

Set the height and width of the popup dialog to the presenting contro…

9592aef

…ller

cla-bot bot added the cla: yes label Oct 31, 2019

slolam added 3 commits October 30, 2019 23:29

dialog options ios attributes presentationStyle, height & width are m…

65931e7

…ade optional

Merge branch 'master' into ios-dialog-size

9af0947

Merge branch 'master' into ios-dialog-size

e02bdd0

manoldonev added the ♥ community PR label Nov 21, 2019

vakrilov self-requested a review November 25, 2019 16:14

vakrilov changed the title ~~feat(iOS popup dialog size): Setting the size of popup dialog thru dialog options~~ feat(dialogs): Setting the size of popup dialog thru dialog options Dec 2, 2019

Merge branch 'master' into ios-dialog-size

b569a60

vakrilov approved these changes Dec 2, 2019

View reviewed changes

Merge branch 'master' into ios-dialog-size

fafbc60

Updated NativeScript.api.md for public API changes

7a94daa

cla-bot bot removed cla: yes ♥ community PR labels Dec 3, 2019

Update with git properties

be2418e

Public API

f4037cc

CLA update

748fb97

Merge branch 'master' into ios-dialog-size

ceead90

Merge branch 'master' into ios-dialog-size

e316a7c

vakrilov merged commit cd5703a into NativeScript:master Dec 5, 2019

slolam deleted the ios-dialog-size branch December 5, 2019 16:09

snyk-bot mentioned this pull request Feb 26, 2020

[Snyk] Upgrade tns-core-modules from 6.3.2 to 6.4.0 raphagoo/runningManApplication#6

Closed

This was referenced Apr 9, 2020

[Snyk] Upgrade tns-core-modules from 6.4.0 to 6.5.0 SchoolSquirrel/nativescript-plugins#35

Merged

[Snyk] Upgrade tns-core-modules from 6.4.0 to 6.5.0 SchoolSquirrel/nativescript-plugins#36

Merged

Uh oh!

feat(dialogs): Setting the size of popup dialog thru dialog options #8041

feat(dialogs): Setting the size of popup dialog thru dialog options #8041

Uh oh!

Conversation

slolam commented Oct 31, 2019 • edited by vakrilov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

What is the current behavior?

What is the new behavior?

Uh oh!

vakrilov commented Dec 2, 2019

Uh oh!

slolam commented Dec 2, 2019

Uh oh!

vakrilov commented Dec 3, 2019

Uh oh!

slolam commented Dec 3, 2019

Uh oh!

cla-bot bot commented Dec 3, 2019

Uh oh!

slolam commented Dec 3, 2019

Uh oh!

cla-bot bot commented Dec 3, 2019

Uh oh!

cla-bot bot commented Dec 3, 2019

Uh oh!

vakrilov commented Dec 3, 2019

Uh oh!

vakrilov commented Dec 4, 2019

Uh oh!

cla-bot bot commented Dec 4, 2019

Uh oh!

slolam commented Dec 4, 2019

Uh oh!

cla-bot bot commented Dec 5, 2019

Uh oh!

cla-bot bot commented Dec 5, 2019

Uh oh!

dtopuzov commented Dec 5, 2019

Uh oh!

vakrilov commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slolam commented Dec 5, 2019

Uh oh!

Uh oh!

slolam commented Oct 31, 2019 •

edited by vakrilov

Loading

vakrilov commented Dec 5, 2019 •

edited

Loading