fix(css): parse issue with new Webpacked AST css/scss files #8380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Webpack 1.50 (1.40?) now pre-parses CSS/SCSS using the 'css-loader' and includes the AST for the CSS instead of the raw CSS. This now causes breaking issues when you use
addTaggedAdditionalCSS
as the file that is webpacked is now no longer CSS, but an AST tree.All apps that used require(css/scss) with
addTaggedAdditionalCSS
are now broken.What is the new behavior?
This changes the
addTaggedAdditionalCSS
to actual run the same detection code that is used in thefromURI
, and abstracts that code into a new functionfromDetect
Now bothfromURI
andaddTaggedAdditionalCSS
callfromDetect
so they share the same logic to detect which way the css was handled.This PR FIXES a BREAKING change caused by a change in the Webpack configuration...