fix(webpack): apply-css-loader not applying css #8811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
approved these changes
Sep 3, 2020
|
Looks like broken again in 3.0.2 release. |
|
@romandragan has not been released yet - only in |
|
Released in 3.0.3! |
tarunama
pushed a commit
to tarunama/NativeScript
that referenced
this pull request
Sep 9, 2020
* fix(webpack): apply-css-loader not applying css * chore: bump webpack version to rc * fix: import style scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that everything is using ES modules, the
exportsobject no longer exists.css-loaderadds the___CSS_LOADER_EXPORT___variable to the module, and then exports it. This allows us to hook into it, and apply the css to a NativeScript app.This fixes Vue apps in NativeScript 7. See nativescript-vue/nativescript-vue#715
I believe
require("@nativescript/core/ui/styling/style-scope")is no longer needed - because globals are handled differently (testing the change in an app works fine) - but @NathanWalker please take a look!The change has been released under
3.0.1-rc.0.