Skip to content

feat: boolean to disable systemAppearanceChanged (theme) #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2020
Merged

feat: boolean to disable systemAppearanceChanged (theme) #8827

merged 2 commits into from
Sep 9, 2020

Conversation

farfromrefug
Copy link
Collaborator

With es2017 @nativescript/theme wont work because of an error like that

Cannot set property systemAppearanceChanged of #<Object> which has only a getter

Now i think it is best to not "override" that method but to have a boolean to disable

@cla-bot cla-bot bot added the cla: yes label Sep 8, 2020
NathanWalker
NathanWalker approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@NathanWalker NathanWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NathanWalker NathanWalker merged commit 5286adf into NativeScript:master Sep 9, 2020
tarunama pushed a commit to tarunama/NativeScript that referenced this pull request Sep 9, 2020
@farfromrefug @tarunama
feat(core): boolean to disable systemAppearanceChanged (theme) (Nativ…
bcabee2 
…eScript#8827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farfromrefug @NathanWalker