Skip to content

fix(ios): time-picker and date-picker for iOS 14 #8876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix(ios): time-picker and date-picker for iOS 14 #8876

merged 1 commit into from
Sep 23, 2020

Conversation

asharghi
Copy link
Contributor

PR Checklist

What is the current behavior?

TimePicker/DatePicker crashes on iOS 14

What is the new behavior?

Does not crash

Fixes/Implements/Closes #8862

@cla-bot cla-bot bot added the cla: yes label Sep 21, 2020
@NathanWalker
Copy link
Contributor

And you even backported to {N} 6 - stellar 😍

@asciidiego
Copy link

@NathanWalker how do you know that it has been backported to {N} 6? Just to know for future PRs!

As in, what are the "rules" or "tests" that have to pass that make sure that an earlier version keeps working?

@asharghi asharghi mentioned this pull request Sep 23, 2020
Closed
@alexander-mai alexander-mai mentioned this pull request Sep 23, 2020
Merged
@NathanWalker
Copy link
Contributor

NathanWalker commented Sep 23, 2020 •
edited
Loading

@diegovincent If you ever see a PR posted which targets the tns-core-modules branch 👍

Screen Shot 2020-09-23 at 7 55 51 AM

@NathanWalker NathanWalker merged commit e1318b1 into NativeScript:tns-core-modules Sep 23, 2020
@alexander-mai alexander-mai mentioned this pull request Sep 24, 2020
Merged
NathanWalker pushed a commit to NativeScript/plugins that referenced this pull request Sep 29, 2020
@alexander-mai
fix(datetimepicker): ios 14 support (#14)
e614e2d 
* changes from NativeScript/NativeScript#8876

closes NativeScript/nativescript-datetimepicker#75
NathanWalker pushed a commit to NativeScript/plugins that referenced this pull request Oct 7, 2020
@alexander-mai
fix(datetimepicker): use native color (#22)
a8ca205 
* Fix #11

* changes from NativeScript/NativeScript#8876

* Fix NativeScript/nativescript-datetimepicker#78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asharghi @NathanWalker @asciidiego