fix(ios): preferredDatePickerStyle property #8899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
NathanWalker
previously approved these changes
Sep 25, 2020
This was referenced Sep 25, 2020
Closed
NathanWalker
approved these changes
Sep 25, 2020
d4ced42 to
53488b5
Compare
| @@ -98,6 +98,7 @@ export abstract class TimePickerBase extends View implements TimePickerDefinitio | |||
| public maxHour: number; | |||
| public minMinute: number; | |||
| public maxMinute: number; | |||
| public iosPreferredDatePickerStyle: number; | |||
There was a problem hiding this comment.
Shouldn't this be iosPreferredTimePickerStyle instead of iosPreferredDatePickerStyle. Because this is the time-picker component and not the date-picker component
There was a problem hiding this comment.
It's named after what Apple has called it https://developer.apple.com/documentation/uikit/uidatepicker/3526124-preferreddatepickerstyle
There was a problem hiding this comment.
Okay, then I understand it. First I thought huh is this a mistake? Because it's a time picker component and not a date picker component. But now I understand why it's that name. Thanks for explaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for the discussion at #8877 (comment)
I will add the same property to the datetime element after I have gotten feedback