Skip to content

fix(webpack): exclude files starting with _ from require.context #9596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Oct 5, 2021

PR Checklist

What is the current behavior?

In plain flavors (TypeScript and JavaScript), having scss files starting with _ are not ignored from the require.context causing build errors because they are treated as root stylesheets.

What is the new behavior?

Files starting with an _ are now properly ignored from the require.context() that maps out all the files in the app and will no longer cause build errors due to treating these stylesheets as root ones.

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Oct 5, 2021
@rigor789 rigor789 merged commit 9929833 into master Oct 6, 2021
@rigor789 rigor789 deleted the fix/webpack-context-exclusions branch October 6, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant