feat: improved background handling #9615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: refactor background handling. The idea is for views to handle sepecial case themselves. I realised that android.widget.Button was materialized even if you were not using it because there was a test for instanceof in the background handling. Now the special background handling is done in Button and ActionBar * fix: automated tests are now passing * fix: removed duplicated line * fix: port boxshadow to background improvements * Update packages/core/ui/core/view/index.android.ts Co-authored-by: Igor Randjelovic <rigor789@gmail.com> * Update packages/core/ui/action-bar/index.android.ts Co-authored-by: Igor Randjelovic <rigor789@gmail.com> * chore: remove empty namespace Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
NathanWalker
pushed a commit
that referenced
this pull request
Jan 22, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Jan 22, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Feb 14, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Feb 15, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Feb 18, 2022
NathanWalker
pushed a commit
that referenced
this pull request
Mar 1, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.