Skip to content

feat(root-layout): support gradient colors on shade cover #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 14, 2022
Merged

feat(root-layout): support gradient colors on shade cover #9626

merged 6 commits into from
Jan 14, 2022

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 28, 2021 •
edited
Loading

PR Checklist

What is the current behavior?

Right now only standard hex/rgb(a) color values are supported via the RootLayout api, e.g.

getRootLayout()
        .open(view, {
          shadeCover: {
            color: 'rgba(0,0,0,.5)',

What is the new behavior?

This maintains the existing behavior while also supporting linear-gradient as well, e.g.

getRootLayout()
        .open(view, {
          shadeCover: {
            color: 'linear-gradient(to top, #fff, rgba(0, 0, 0, .7))',

@cla-bot cla-bot bot added the cla: yes label Oct 28, 2021
@NathanWalker NathanWalker added this to the 8.2 milestone Oct 28, 2021
@NathanWalker NathanWalker self-assigned this Oct 28, 2021
@NathanWalker NathanWalker force-pushed the feat/rootlayout-gradient-shadecover branch from f55e62d to 9495910 Compare October 28, 2021 23:19
@NathanWalker NathanWalker marked this pull request as ready for review December 16, 2021 16:07
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 January 14, 2022 05:41
@NathanWalker NathanWalker merged commit 06c00d2 into release/8.2.0 Jan 14, 2022
@NathanWalker NathanWalker deleted the feat/rootlayout-gradient-shadecover branch January 14, 2022 05:41
NathanWalker added a commit that referenced this pull request Feb 14, 2022
@NathanWalker @williamjuan027
feat(root-layout): support gradient colors on shade cover (#9626)
d019c40 
Co-authored-by: William Juan <williamjuan027@gmail.com>
NathanWalker added a commit that referenced this pull request Feb 18, 2022
@NathanWalker @williamjuan027
feat(root-layout): support gradient colors on shade cover (#9626)
cf63281 
Co-authored-by: William Juan <williamjuan027@gmail.com>
NathanWalker added a commit that referenced this pull request Mar 1, 2022
@NathanWalker @williamjuan027
feat(root-layout): support gradient colors on shade cover (#9626)
d756eb5 
Co-authored-by: William Juan <williamjuan027@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NathanWalker NathanWalker

Labels
cla: yes enhancement feature hacktoberfest
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanWalker @williamjuan027