fix(core): Font icons had incorrect fallback size in android #9914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into NativeScript:alpha from CatchABus:android-font-icon-size-fix

May 19, 2022

Contributor

CatchABus commented May 19, 2022

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

The font icon size that works as a fallback value is incorrect.

What is the new behavior?

The font icon size that works as a fallback value will be incorrect.


          fix(core): Font icons had incorrect fallback size in android.

779a4a9

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 4f312a3 into NativeScript:alpha

NathanWalker pushed a commit that referenced this pull request


          fix(android): font icons had incorrect fallback size (#9914)

2d9c4f2

NathanWalker pushed a commit that referenced this pull request


          fix(android): font icons had incorrect fallback size (#9914)

e8bed44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels