Skip to content

feat: Rename methods with conflicting jsName-s #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

feat: Rename methods with conflicting jsName-s #64

merged 1 commit into from
Dec 4, 2018

Conversation

tdermendjiev
Copy link
Contributor

Same logic as for C-functions is implemented for Objective-C methods - colliding methods are added postfix "-Method(index)".

For example:

-(void)collisionMethodWith:(float)param p1:(int)a p2: (NSString*) p2;
-(void)collisionMethod:(float)param withP1:(int)a p2: (NSString*) p2;
-(void)collisionMethod:(float)param with:(int)a p1P2: (NSString*) p2;

are renamed as:

collisionMethodWithP1P2(param: number, a: number, p2: string): void;
collisionMethodWithP1P2Method(param: number, a: number, p2: string): void;
collisionMethodWithP1P2Method2(param: number, a: number, p2: string): void;

@tdermendjiev tdermendjiev self-assigned this Oct 29, 2018
@tdermendjiev tdermendjiev force-pushed the tdermendzhiev/resolve-method-collisions branch from 2e0c933 to 530c570 Compare October 29, 2018 12:21
@mbektchiev mbektchiev merged commit e2acaf6 into master Dec 4, 2018
@mbektchiev mbektchiev deleted the tdermendzhiev/resolve-method-collisions branch December 4, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbektchiev mbektchiev mbektchiev approved these changes

Assignees

@tdermendjiev tdermendjiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdermendjiev @mbektchiev