Action bar directives #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooooohhh ma goodness. This is exciting. @vakrilov Awesome. |
|
@vakrilov Nice |
| selector: "ActionBar", | ||
| template: "<ng-content></ng-content>" | ||
| }) | ||
| export class ActionBarDirective { |
There was a problem hiding this comment.
Rename to ActionBarComponent? Not a directive anymore.
|
Just had a chat with @vakrilov and we decided to rename |
| }) | ||
| export class ActionBarDirective { | ||
| constructor(public element: ElementRef, private page: Page) { | ||
| console.log("ActionBarDirective.constructor: " + element.nativeElement) |
There was a problem hiding this comment.
We should switch all those console.log statements to util.traceLog
8c50131 to
20f3eee
Compare
|
Guys, what's the way to change the title using the ActionBarExtension component? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55
Ping: @hdeshev @nsndeck