Skip to content

fix(TabViewItemDirective ): textTransform property added #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 21, 2018
Merged

fix(TabViewItemDirective ): textTransform property added #1315

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d2a2a9
textTransform property to TabViewItemDirective
bhavincb May 2, 2018
cf9e640
Merge pull request #1 from bhavincb/bhavincb-patch-1
bhavincb May 2, 2018
c80bf26
Merge branch 'master' into master
bhavincb May 7, 2018
b833445
removed tailing whitespace
bhavincb May 7, 2018
1f1cf53
Merge branch 'master' into master
MartoYankov May 17, 2018
88ca581
Merge branch 'master' into master
SvetoslavTsenov May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions nativescript-angular/directives/tab-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
ViewContainerRef,
} from "@angular/core";
import { TabView, TabViewItem } from "tns-core-modules/ui/tab-view";
import { TextTransform } from "tns-core-modules/ui/text-base";

import { InvisibleNode } from "../element-registry";
import { rendererLog } from "../trace";
Expand Down Expand Up @@ -53,6 +54,7 @@ export class TabViewItemDirective implements OnInit {
private item: TabViewItem;
private _title: string;
private _iconSource: string;
private _textTransform: TextTransform;

constructor(
private owner: TabViewDirective,
Expand Down Expand Up @@ -89,6 +91,20 @@ export class TabViewItemDirective implements OnInit {
}
}


@Input()
get textTransform() {
return this._textTransform;
}

set textTransform(value: TextTransform) {
if (this._textTransform !== value) {
this._textTransform = value;
this.ensureItem();
this.item.textTransform = this._textTransform;
}
}

private ensureItem() {
if (!this.item) {
this.item = new TabViewItem();
Expand All @@ -100,6 +116,7 @@ export class TabViewItemDirective implements OnInit {
if (this.config) {
this.item.title = this._title || this.config.title;
this.item.iconSource = this._iconSource || this.config.iconSource;
this.item.textTransform = this._textTransform || this.config.textTransform;
}

const viewRef = this.viewContainer.createEmbeddedView(this.templateRef);
Expand Down