Skip to content

fix-next(tabview): set default android text transform #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2018
Merged

fix-next(tabview): set default android text transform #1343

merged 2 commits into from
May 23, 2018

Conversation

MartoYankov
Copy link
Contributor

An issue came out of #1315. TabViewItem textTransform has a default value for Android that kick in only if no value (even a null value) is set.

Note: Will need to change an image in the ui tests.

@MartoYankov MartoYankov added this to the 6.0 milestone May 22, 2018
@MartoYankov MartoYankov self-assigned this May 22, 2018
@ghost ghost added the in progress label May 22, 2018
@ghost ghost assigned dtopuzov May 23, 2018
@sis0k0 sis0k0 changed the title chore(tabview): set default android text transform fix-next(tabview): set default android text transform May 23, 2018
@sis0k0 sis0k0 merged commit 4943a3e into master May 23, 2018
@ghost ghost removed the in progress label May 23, 2018
@SvetoslavTsenov SvetoslavTsenov deleted the myankov/tabviewitem-default branch January 31, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@manoldonev manoldonev manoldonev approved these changes

@sis0k0 sis0k0 sis0k0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MartoYankov MartoYankov

@dtopuzov dtopuzov

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MartoYankov @manoldonev @sis0k0 @dtopuzov