Skip to content

fix: polyfill global.Node for angular testing #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

Angular 11 introduced a regression where they check instanceof Node, but Node is not polyfilled by Nativescript so it errors out.

What is the new behavior?

Node is polyfilled with a dummy class.

Fixes #2311.

@cla-bot cla-bot bot added the cla: yes label Mar 31, 2021
@NathanWalker NathanWalker merged commit c4ab491 into master Apr 6, 2021
@NathanWalker NathanWalker deleted the edusperoni/node-polyfill branch April 6, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node is not defined when running jasmine tests with karma
2 participants