Skip to content

Support Angular RC5 #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Aug 30, 2016
Merged

Support Angular RC5 #405

merged 25 commits into from
Aug 30, 2016

Conversation

hdeshev
Copy link
Contributor

@hdeshev hdeshev commented Aug 19, 2016 •
edited
Loading

The Mother of All Pull Requests!

  • Migrate to Angular 2 RC5.
  • Bootstrapping apps now done with NgModule's. The old nativescriptBootstrap method is gone, and apps should switch to the platformNativeScriptDynamic().bootstrapModule(MyAppModule) API. Yes, ALL CLIENT APPS NEED TO BE CHANGED
  • The library entrypoint is now the nativescript-angular/platform module. Import NativeScriptRouterModule from nativescript-angular/router and NativeScriptFormsModule from nativescript-angular/forms respectively if you want to use routing and form value accessor directives.
  • Remove all traces of router-deprecated.

Known Issues

  • Karma test runner almost always hangs on Travis (yes, again!)
  • tests/app/tests/snippets.ts test never raises router NavigationStart event.

Ping @nsndeck, @vakrilov

@hdeshev
Copy link
Contributor Author

hdeshev commented Aug 19, 2016

I published the package to npm as version 0.4.0-beta1 under the angular2-rc5, so people could try it out easily :)

@nsndeck
Copy link
Contributor

nsndeck commented Aug 19, 2016

👍

1 similar comment
@vakrilov
Copy link
Contributor

👍

@mko
Copy link

mko commented Aug 26, 2016

Any idea when this will be integrated?

@mko mko mentioned this pull request Aug 27, 2016
Closed
@NathanWalker
Copy link
Contributor

@hdeshev I was able to use the 0.4.0-beta1 tag to update https://github.com/NathanWalker/angular2-seed-advanced to rc.5 and it works great.
Thank you for that 👍

@hdeshev hdeshev force-pushed the hdeshev/ng-rc5 branch 3 times, most recently from 9b027ed to 7dd4b0e Compare August 30, 2016 13:03
hdeshev added 21 commits August 30, 2016 16:03
@hdeshev
Remove router-deprecated, lowercase animation example files.
4cf2a1c
@hdeshev
Temporary compile-only fix for animation code.
657e6cc
@hdeshev
Switch to Angular 2 rc5 dependencies
e4a10aa
@hdeshev
Define a NgModule and platform
26545be
@hdeshev
Migrate value accessors to new @angular/forms module
b1d427f 
No longer using forms-deprecated.
@hdeshev
Update ng-sample with a RendererTest NgModule
ed46d65
@hdeshev
Add forms module. Throw in an empty router module too.
3720541
@hdeshev
RouterModule now with providers. Default router-outlet example.
e20fe8c
@hdeshev
Fix PageRouterOutlet for rc5. Get first example running.
a735506
@hdeshev
Port the rest of the router examples to rc5.
a032115
@hdeshev
Fix animation for rc5. Port animation examples too.
ff5b703
@hdeshev
Fix ActionBarTest example for rc5
4f5e281
@hdeshev
Update livesync (CSS/templates) for rc5
8df4ef5
@hdeshev
Allow advanced platform bootstraps via AppOptions.
6032993
@hdeshev
Change tests dependencies to rc5
cbf3279
@hdeshev
Boot multiple apps in tests using rc5 modules.
ba3f250 
Fix compile errors in http and style-properties examples
@hdeshev
Fix karma tests for rc5.
66b9a55
@hdeshev
Delete nativescript-angular/application module.
e9a442e 
nativescript-angular/platform is the new cool thing.
@hdeshev
Use tns install in .travis.yml
fded5f4
@hdeshev
Update changelog for rc5
86511b3
@hdeshev
Version bump: 0.4.0
55bee82
hdeshev and others added 4 commits August 30, 2016 16:03
@hdeshev
Disable Karma tests on Travis
4fa1649
@hdeshev
Fix Appium tests by tweaking timeouts.
7dd4b0e 
- Switch to Node 6.4.0 for Travis.
- Add explicit timeouts in appium test initial waits.
- Get rid of explicit platform add.
@NathanWalker @hdeshev
chore: cleanup and proper ng-sample package
4812bca
@NathanWalker @hdeshev
chore: update iOS resources to latest
f4d9d32
@hdeshev hdeshev merged commit 20120f2 into master Aug 30, 2016
@sis0k0 sis0k0 deleted the hdeshev/ng-rc5 branch August 3, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hdeshev @nsndeck @vakrilov @mko @NathanWalker